Ken Rickard comments

Results 20 comments of


                                            Ken Rickard

Drupal's EventDisapatcher is incompatible with Symfony; throws error

I bypassed this with `/** @phpstan-ignore-next-line */`

Testing for PHP 7 on Drupal 8

This seems to fix the issue: ```before_script: # Other setup tasks # Drupal installation # Update PHPUnit. - composer run-script drupal-phpunit-upgrade ```

10.2: EntityReferenceTestTrait to EntityReferenceFieldCreationTrait rector using RenameClassRector

@mglaman I fixed the merge conflict here and tests pass locally. Could use another review.

10.2: EntityReferenceTestTrait to EntityReferenceFieldCreationTrait rector using RenameClassRector

@bbrala @mglaman This PR is green again. Are we good to merge?

Usage of symfony-cmf/routing dependency deprecated

@mglaman More odd conflicts

Add $defaultTheme property if missing on BrowserTestBase

@mglaman This one has a merge conflict I am uncertain about

Drupal's EventDisapatcher is incompatible with Symfony; throws error

Looks like this can be fixed by following https://www.drupal.org/node/3159012 UPDATE: No, the code already follows that pattern.

Drupal's EventDisapatcher is incompatible with Symfony; throws error

I bypassed this with `/** @phpstan-ignore-next-line */`

New rector (10.1): drupal_theme_rebuild is deprecated

This PR is irrelevant as it stands now, since this script pulls Drupal 8.0.x. We should update with a matrix, similar to that used here: https://github.com/agentrickard/domain/blob/8.x-1.x/.travis.yml