react-pdf-highlighter icon indicating copy to clipboard operation
react-pdf-highlighter copied to clipboard

Small fix for pdfToViewport function

Open davidkong0987 opened this issue 5 years ago • 1 comments

top should be y2 not y1

davidkong0987 avatar Jun 22 '20 06:06 davidkong0987

@davidkong0987 after attempting to do what you suggested here, the result is still very odd. Seems like this function performs some transformation but the rectangle is flipped upside down.


const pdfToViewport = (pdf: Scaled, viewport: Viewport): LTWHP => {
  const [x1, y1, x2, y2] = viewport.convertToViewportRectangle([
    pdf.x1,
    pdf.y1,
    pdf.x2,
    pdf.y2,
  ]);

  return {
    left: x1,
    top: y2,

    width: x2 - x1,
    height: y1 - y2,

    pageNumber: pdf.pageNumber,
  };
};

ch-hristov avatar Feb 11 '22 14:02 ch-hristov

Fixed in #244.

agentcooper avatar Jul 31 '23 08:07 agentcooper