react-pdf-highlighter icon indicating copy to clipboard operation
react-pdf-highlighter copied to clipboard

Fix v5.4.0, bump to pdfjs-dist v2.13.216

Open OscarBC opened this issue 2 years ago • 2 comments

Hello, @agentcooper after testing the v5.0.4 released yesterday I wasn't able to see the pdf on the create-react-app example. After fixing the packages (and upgrading some) I was able to run the create-react-app-expample.

Changes I did:

  1. Removed @types/pdfjs-dist since it isn't needed because pdfs-dis already includes it.
  2. Upgraded pdfjs-dist to the latest version
  3. Implemented the Null10n class included with pdfjs.
  4. Installed as dev-dependencies the react and react-dom packages (because with these I wasn't able to run vite)
  5. Updated react-scripts package (to v5.0.0) and moved it to the dev-dependencies in the example project to mitigate 96 high security warnings with npm-audit. I tested it making a build and it builded and worked correctly.

OscarBC avatar Mar 23 '22 23:03 OscarBC

I guess I should bump the version to v5.4.1

OscarBC avatar Mar 24 '22 01:03 OscarBC

@OscarBC I did a checkout on your branch and unfortunately it seems #180 is not fixed, at least on my system.

MacBook-Pro:react-pdf-highlighter kholub$ git status
On branch fix/v5.4.0_fix
Your branch is up to date with 'origin/fix/v5.4.0_fix'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   package-lock.json

no changes added to commit (use "git add" and/or "git commit -a")
MacBook-Pro:react-pdf-highlighter kholub$ rm package-lock.json 
MacBook-Pro:react-pdf-highlighter kholub$ rm -rf node_modules/
MacBook-Pro:react-pdf-highlighter kholub$ npm install
npm WARN deprecated [email protected]: Version no longer supported. Upgrade to @latest

added 597 packages, and audited 598 packages in 16s

36 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
MacBook-Pro:react-pdf-highlighter kholub$ npm start

https://user-images.githubusercontent.com/7282590/160013357-39f408e5-8717-4d44-9f5b-08b50ae41611.mov

holub008 avatar Mar 24 '22 21:03 holub008

Closing as https://github.com/agentcooper/react-pdf-highlighter/pull/214 with update to 2.16.105 was merged. Feel free to reopen if needed.

agentcooper avatar Nov 28 '22 21:11 agentcooper