react-pdf-highlighter icon indicating copy to clipboard operation
react-pdf-highlighter copied to clipboard

Update PDF.js to 2.9

Open Zhechko opened this issue 3 years ago • 9 comments

Zhechko avatar Aug 18 '21 10:08 Zhechko

I've tried updating to 2.9.359, but the highlight position is wrong. It would be great if someone can take a look on how to fix that. image

agentcooper avatar Aug 27 '21 19:08 agentcooper

Would it be helpful to add display: flex to .textLayer in pdf_viewer.css?

cbwchuck avatar Jan 05 '22 17:01 cbwchuck

@cbwchuck thanks, would you be able to open a PR with your suggestion?

agentcooper avatar Jan 05 '22 17:01 agentcooper

@agentcooper Sure! Only concern is I was looking into this issue with pdfjs-dist 2.11.338, not sure whether it will be too big a stride though :)

cbwchuck avatar Jan 05 '22 17:01 cbwchuck

My team has noticed improvements in the text layer (fewer spacing issues) in master with pdf.js 2.11, coming from 2.8. Any ETA for next release? We can try to help out on any outstanding work that needs to be bundled with the release. Thank you both for the great work!

holub008 avatar Mar 22 '22 05:03 holub008

@holub008 Thanks for the reminder. I've released version 5.4.0. Could you please try it and send your feedback?

agentcooper avatar Mar 22 '22 08:03 agentcooper

Awesome! Text selection quality is improved (the attached example would always be missing spaces because every word was wrapped in a span). I believe the improvement is due to this update.

I'm noticing an issue (also on the attached example) where some highlights go missing when doing multi-line selection. Not sure if that's react-pdf-highlighter or our app; I'll get back to you with what we find.

Screen Shot 2022-03-22 at 1 02 59 PM

holub008 avatar Mar 22 '22 18:03 holub008

Moving to https://github.com/agentcooper/react-pdf-highlighter/issues/180

holub008 avatar Mar 22 '22 21:03 holub008

I think I got it, Please see #181.

OscarBC avatar Mar 23 '22 23:03 OscarBC

Closing as PDF.js was updated to 2.16.

agentcooper avatar Nov 29 '22 12:11 agentcooper