Unselect active members by default at handling of payments in default

[Crasher508]

While we handle payments in default, it's hard to separate between members and active members.

Waiting for https://github.com/agdsn/pycroft/pull/780 to be merged since property group "active_member" is missing

[codecov[bot]]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 88.02%. Comparing base (72e87a6) to head (bb8ce48). :warning: Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #786      +/-   ##
===========================================
- Coverage    88.03%   88.02%   -0.01%     
===========================================
  Files          276      276              
  Lines        17104    17091      -13     
===========================================
- Hits         15057    15045      -12     
+ Misses        2047     2046       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[agmes4]

The property was actually set in the database. So it actually is not block by the other merge request

[agmes4]

Also you should add a test for that. You cloud here refactor the function and move the selection of users into pycroft/lib/membership.py, in order to have as little as possible logic in the blueprints. Makes testing also a bit easier

[agmes4]

Just the one comment otherwise looks good and squash it at the end ;)