pycroft icon indicating copy to clipboard operation
pycroft copied to clipboard

confirm group membership ending

Open rouven0 opened this issue 1 year ago • 1 comments

Currently, when you click on the 'End membership' button on a group (intended or accidentally), the group membership is ended without any confirmation, leading to possible unwanted situations.

This PR implements a simple confirmation form before performing the actual ending operation.

rouven0 avatar Dec 02 '24 14:12 rouven0

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.96%. Comparing base (2c6fb8c) to head (0086cf8). Report is 11 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #767      +/-   ##
===========================================
+ Coverage    87.88%   87.96%   +0.08%     
===========================================
  Files          275      275              
  Lines        16953    16982      +29     
===========================================
+ Hits         14899    14939      +40     
+ Misses        2054     2043      -11     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 02 '24 14:12 codecov[bot]

I added the test so we can close this merge request successfully

agmes4 avatar May 12 '25 16:05 agmes4

now its test driven :P

agmes4 avatar May 12 '25 16:05 agmes4

now its test driven :P

Not quite: „test driven“ refers to the ideology that in order to write correct code, you need to write tests first. This makes sense some times, but is unhelpful as a default mentality.

lukasjuhrich avatar May 13 '25 17:05 lukasjuhrich

@agmes4 Nevermind, I now saw the commit order and got the joke…

lukasjuhrich avatar May 13 '25 17:05 lukasjuhrich