pycroft icon indicating copy to clipboard operation
pycroft copied to clipboard

Order-Invariance in search bar

Open LukasGibeh opened this issue 7 years ago • 4 comments

  • the order of search strings entered in the search bar should not matter, e.g. "Max Mustermann" vs. "Mustermann Max".
  • one should be able to find people when typing names incompletely, e.g. "M Mustermann"

LukasGibeh avatar Sep 14 '18 17:09 LukasGibeh

  • when typing ä, ö, ü, ß it should also be searched for ae, oe, ue, ss and vice versa
  • when typing letters without accent (e.g. a), it should also be searched for letters with accent (e.g. á)

LukasGibeh avatar Oct 02 '18 17:10 LukasGibeh

when typing letters without accent (e.g. a), it should also be searched for letters with accent (e.g. á)

This is already working for me, at least for ó.

when typing ä, ö, ü, ß it should also be searched for ae, oe, ue, ss and vice versa

I would rather see our database cleaned up and members having their proper name stored, since this will clutter the search results with false-positives.

toothstone avatar Oct 04 '18 14:10 toothstone

I would rather see our database cleaned up

A database cleanup wouldn't be too much trouble, although it would be preferrable to limit it to people who are members at the moment, just to keep the amount of changed data small – in some cases, the name actually has an ae instead of an ä, for instance, so there will be some names changed for the worse in any case.

lukasjuhrich avatar Oct 04 '18 20:10 lukasjuhrich

Besides character equivalence, the big feature @LukasGibeh is tracing here is tokenization of the search string by splitting into spaces, so the search endpoint can do an inclusive-or search perhaps weighted by the direction of the tokens or similar. There's many levels of complexity one can pursue with such a feature, which is to be discussed in more detail if that's deemed an improtant feature.

lukasjuhrich avatar Oct 04 '18 20:10 lukasjuhrich