cubical
cubical copied to clipboard
agda
#885: Update README, inform about reviewing
How about including our Github handles together with our names?
Yes - but I would turn the list into a table then...
I like it - what do you think: https://github.com/felixwellen/cubical/tree/885_update_readme#reviewing-of-pull-requests
I sorted stuff in the README by topic and threw in some headlines. Someone with knowledge of this stuff should look at it: @mortberg
Everything looks good to me. Will it be possible that people request reviews from me, without me being able to merge PRs?
Everything looks good to me. Will it be possible that people request reviews from me, without me being able to merge PRs?
Sure, you can review and someone else merges
@ecavallo What do you want listed as your area of expertise? Most things?
I guess you mean the same as you area of expertise, which is "Most topics"?
Putting this back to 'draft' - maybe it is better, if we actually use the 'Assign' field of the PRs. That way it is much easier, to get an overview of unassigned PRs and we could use the convention that whoever is assigned to an PR should take care of finding a reviewer or whatever else there might be to do (so a bit like the editor-role, but it is ok to review something yourself).
Putting this back to 'draft' - maybe it is better, if we actually use the 'Assign' field of the PRs. That way it is much easier, to get an overview of unassigned PRs and we could use the convention that whoever is assigned to an PR should take care of finding a reviewer or whatever else there might be to do (so a bit like the editor-role, but it is ok to review something yourself).
Yeah, I was wondering what the point of assigning PRs was... So should we go for assigning in addition to requesting?
There was one open question: Should we make use of assigning PRs? But I'll write an issue for that and we discuss it on the next meeting. So, yes, ready to merge.
algebra for Max and synthetic homotopy/cohomology theory for Axel.
how about including our Github handles with our names?
On Thu, Aug 11, 2022, 11:07 Felix Cherubini @.***> wrote:
@.**** commented on this pull request.
In README.md https://github.com/agda/cubical/pull/887#discussion_r943261954:
-
+* Andrea Vezzosi (inactive)
I added them. Any hints for their topics?
— Reply to this email directly, view it on GitHub https://github.com/agda/cubical/pull/887#discussion_r943261954, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIE27NHPVT23GI7YS2NSYTVYS7DPANCNFSM56HD6XEA . You are receiving this because you commented.Message ID: @.***>