agda-stdlib icon indicating copy to clipboard operation
agda-stdlib copied to clipboard

[Add] Initial files for Domain theory

Open jmougeot opened this issue 7 months ago • 4 comments

This draft pull request introduces three new files under src/Relation/Binary/Domain, providing foundational modules for domain theory in the Agda standard library. The new modules include definitions and structures such as DCPO, Lub, and ScottContinuous, aiming to extend the library's support for domain-theoretic formalizations. This is an initial draft and feedback is welcome on the design and implementation.

For the second part see the pull request : [Add] Properties for DCPOs

The definition of Lub provided here is likely better placed elsewhere in the library and may require a different name. For further discussion, see issue #2717.

Source

1Lab library

jmougeot avatar May 26 '25 21:05 jmougeot

Any particular reason to introduce this material as a separate sub-hierarchy under Relation.Binary.Domain?

jamesmckinna avatar May 28 '25 15:05 jamesmckinna

Any particular reason to introduce this material as a separate sub-hierarchy under Relation.Binary.Domain?

Increased findability, because of the occurrence of Domain, I would think. This is a port from 1lab, where it uses an Order hierarchy where we "bury" a lot of stuff down into Relation.Binary. In retrospect, I think 1lab's scheme is better.

In any case, for agda-stdlib, the clear precedent is that Lattice hierarchy, which this follows.

JacquesCarette avatar May 28 '25 18:05 JacquesCarette

Could you please resolve the CHANGELOG conflicts?

JacquesCarette avatar Jun 19 '25 14:06 JacquesCarette

Also: you don't seem to have addressed the latest 2 items that I asked about?

JacquesCarette avatar Jun 19 '25 14:06 JacquesCarette

Depending on what others think (and my review being taken into account), I do think this could make it to 2.3.

JacquesCarette avatar Jun 26 '25 15:06 JacquesCarette

Suggest that we close in favour of #2809 ?

jamesmckinna avatar Aug 14 '25 15:08 jamesmckinna

Since the attributions are correct in that further PR, it's probably best to close this one.

JacquesCarette avatar Aug 22 '25 18:08 JacquesCarette