agda-stdlib icon indicating copy to clipboard operation
agda-stdlib copied to clipboard

Fix the mentions of defunct `README` modules

Open gallais opened this issue 5 years ago • 6 comments

In Data.Nat.Tactic.RingSolver we tell people to

See README.Nat for examples of how to use this solver

But README.Nat does not exist anymore. We probably meant to point to README.Tactic.RingSolver instead.

Ideally this kind of sanity check should be part of GenerateEverything.

gallais avatar Dec 14 '20 02:12 gallais

And, less ideally because not machine-checkable, advice in HACKING or style-guide on checking this manually? Or: for every module X, which mentions a README.* module, associate an additional module... X.READMEs (?) which only imports X and all the READMEs that X mentions? Can this (easily) be done automagically by GenerateEverything?

jamesmckinna avatar Jan 13 '24 15:01 jamesmckinna

Any solution to this really ought to be automatable, otherwise it's going to grow into a nightmare.

If our source files were literate, the the reference would be a proper link, which would have broken and thus we would have known to fix it. Is that maybe the best path forward?

JacquesCarette avatar Jan 19 '24 20:01 JacquesCarette

That would be a big upgrade in ux (making stdlib literate), but also at a big cost, not least in (working out to to trade off) the perhaps-competing forces in the design of the library?

jamesmckinna avatar Jan 20 '24 09:01 jamesmckinna

I was thinking it would be done incrementally, i.e. simply start by allowing .lagda as input. In fact, we should take a serious look at all of the 1lab's infrastructure -- it is much nicer than stdlib's and sure seems to work well.

JacquesCarette avatar Jan 20 '24 13:01 JacquesCarette

Suggest closing this after #2285 in favour of opening a fresh issue on README/CI?

jamesmckinna avatar Feb 14 '24 13:02 jamesmckinna

Agreed, once there is such a fresh issue, this one should be closed.

JacquesCarette avatar Feb 14 '24 13:02 JacquesCarette