ansible-synology-dsm icon indicating copy to clipboard operation
ansible-synology-dsm copied to clipboard

Support more scenarios

Open weshouman opened this issue 5 years ago • 4 comments

Support the following

  • Scenarios where multi strings are templated.
  • Use of array of elements alongside with the default values.
  • logout method.
  • Many more methods.

weshouman avatar Apr 06 '20 00:04 weshouman

The main feedback that I have on this is that there's no way to disable the application of a bunch of this new configuration. For example, for the mail settings, there's no options other than disabling mail or actually configuring everything. I don't really have a good suggestion for how to implement the third option of leaving it alone, though.

agaffney avatar Apr 06 '20 23:04 agaffney

Keeping some settings untouched shall be done with a check for each setting whether it's configured for the task or not. This could be implemented by eliminating the use of multi-strings for the compound settings and (of course we know each option whether optional or not, ie: have a clear API)

Note: some options could be tricky, ie: password and __CiPhErTeXt, one and only of them is required for the user creation.

weshouman avatar Apr 07 '20 04:04 weshouman

Are you planning on completing the task/vpnserver stuff? Otherwise it might be better to remove the empty files.

FYI: I don’t need it as I have my vpn configured on pfSense.

rlenferink avatar Jun 10 '20 21:06 rlenferink

The main feedback that I have on this is that there's no way to disable the application of a bunch of this new configuration. For example, for the mail settings, there's no options other than disabling mail or actually configuring everything. I don't really have a good suggestion for how to implement the third option of leaving it alone, though.

The suggestion I have is to put sensible defaults in place. The default should be the same as after a fresh installation.

rlenferink avatar Jun 10 '20 21:06 rlenferink