ag2 icon indicating copy to clipboard operation
ag2 copied to clipboard

fix: missing await on async calls and bedrock keyerror

Open priyansh4320 opened this issue 1 month ago • 2 comments

Why are these changes needed?

This PR is a fix on: Bedrock: handle optional tool params without KeyError.

  • standardize async detection across Agent by using is_coroutine_callable

Related issue number

#2219 #2218

Checks

  • [ ] I've included any doc changes needed for https://docs.ag2.ai/. See https://docs.ag2.ai/latest/docs/contributor-guide/documentation/ to build and test documentation locally.
  • [ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
  • [x] I've made sure all auto checks have passed.

priyansh4320 avatar Nov 21 '25 10:11 priyansh4320

Joggr failed to analyze the pull request, please try again later or contact support.

joggrbot[bot] avatar Nov 21 '25 10:11 joggrbot[bot]

@priyansh4320 As mentioned in the other PR, we need integration tests with real API calls for all LLM client related features to make sure it works. @marklysze may be able to help you get the API access.

randombet avatar Dec 03 '25 18:12 randombet

Codecov Report

:x: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
autogen/agentchat/conversable_agent.py 91.66% 0 Missing and 1 partial :warning:
Files with missing lines Coverage Δ
autogen/oai/bedrock.py 33.84% <100.00%> (-12.86%) :arrow_down:
autogen/agentchat/conversable_agent.py 65.12% <91.66%> (-3.58%) :arrow_down:

... and 39 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 08 '25 13:12 codecov[bot]