Alex Crome

Results 110 comments of Alex Crome

I've got part of an implementation by adding a `WithImageReference()` (e.g. `WithImageReference("myorg.azurecr.io/docker.io/library/redis:tag")`. I've wired that up to `AddContainer` which works, but introduced a breaking change. I also tried replacing `WithImage`...

@danegsta yup, I used that regex with a small addition to handle ipv6 addresses - https://github.com/dotnet/aspire/blob/ea985ec4fd70b9eb8cb2f8c1a567372f5475c89c/src/Aspire.Hosting/Utils/ContainerReferenceParser.cs#L40

To me the main reason to make this change is to help a user, possibly using aspire for the first time, who may try to do the following. ```cs var...

> WithImage method AFTER a WithImageTag/WithImageRegistry call in their builder I was going to give registry mirrors as a counter point of a case where you'll want to call `WithImage`...

Based on the feedback from #5835, trying to split out the image registry from the image is causing some complications leading to the PR being unmergeable. I think I'm going...

Incremental checks on Labels would need to ignore the `ContainerGenerateLabelsImageCreated` labels that get defaulted to the current time. Or perhaps there we can use another more stable date that can...

For context, here is my "real" test, as opposed to the strip down minimal reproduction above. This is for testing a component that scrapes prometheus metric endpoints, to forward them...

I've been able to get my local test passing by moving from using the `endpointAnnotation.AllocatedEndpoint` setter to the following: ```cs var endpointAnnotation = resource.Annotations.OfType().Single(); var allocatedEndpoint = new AllocatedEndpoint(endpointAnnotation, KnownHostNames.DockerDesktopHostBridge,...

Now you point it out, I can see it, but I'd still argue it was hidden as the warning dominated it. I even logged #6961 around the same time and...

~~There is an option for this already - https://backstage.io/docs/integrations/azure/org/#user-photos~~