Andy Seaborne

Results 454 comments of Andy Seaborne

This PR fails with: ``` [INFO] --- frontend:1.15.1:yarn (yarn run build) @ jena-fuseki-ui --- [INFO] Running 'yarn run build' in /home/afs/ASF/jena-review/jena-fuseki2/jena-fuseki-ui [INFO] yarn run v1.22.17 [INFO] $ vite build [INFO]...

I tried it out and didn't come across any issues so looks good to merge to me.

This is "quite big". Is there a best place to start reviewing to break up the feedback?

"git rebase main" works with one update for some Junit4 code.

The Fuseki module contains an HTML interface that includes a control to stop an update or query execution. 1. It is per dataset so there isn't a single page of...

`DatasetGraph` is local, fine grained for code usage and Jena-specific. Something somewhere has to implement storage. The world could be built on this but it will be unsatisfactory because it...

@Aklakan -- In order to make progress, can this be split into multiple PRs? The first would be broken down into changes in ARQ for async. This would give us...

General comment - when (if!) there is a switch to Fuseki Main + UI + Admin for the standalone server (`jena-fuseki-fulljar` and the jars file in the download), there maybe...

The builder is available in `FusekiModule.prepare` but builder is limited as it has a fixed contract. Some custom arguments may be complete separate from building. The extensions would ideally not...

@rvesse -- I'm working on a PR with material taken from #2773 that focuses on just a customised command line. I think there needs to more steps in the customisation...