Andy Seaborne

Results 454 comments of Andy Seaborne

Running `mvn clean install` Sorry - fixing licenses is something the submitter has to do. ``` Files with unapproved licenses: jena-benchmarks/jena-benchmarks-jmh/src/test/java/org/apache/jena/sparql/engine/join/QueryTaskCurrent.java jena-benchmarks/jena-benchmarks-jmh/src/test/java/org/apache/jena/sparql/engine/join/QueryTask480.java jena-benchmarks/jena-benchmarks-jmh/src/test/java/org/apache/jena/sparql/engine/join/TestHashJoin.java jena-benchmarks/jena-benchmarks-jmh/src/test/java/org/apache/jena/sparql/engine/benchmark/QueryTask.java jena-benchmarks/jena-benchmarks-jmh/src/test/java/org/apache/jena/sparql/engine/benchmark/QueryTaskResult.java jena-benchmarks/jena-benchmarks-jmh/src/test/java/org/apache/jena/sparql/engine/benchmark/QueryTaskReader.java jena-arq/src/main/java/org/apache/jena/sparql/engine/join/ImmutableUniqueList.java ``` other than...

Hi @Aklakan, Just checking - is this stable now?

This is looking good. I rebased to current main and tested. Added a few comments - and I agree with @arne-bdt 's comments.

> Feel free to point me to the parts of the code for which I should provide clarifications. Some overall description (a general outline, not every detail) would be helpful...

@Aklakan These file don't have the license header: ``` jena-arq/src/test/java/org/apache/jena/sparql/engine/join/TestBitSetMapper.java jena-arq/src/test/java/org/apache/jena/sparql/engine/join/TestMultiHashProbeTable.java jena-arq/src/test/java/org/apache/jena/sparql/engine/join/TestJoinKey.java ``` This is tested for by the maven build (`mvn clean install`) or can be run directly with...

Seems to work for me - this PR, rebased to current main. `yarn run test:e2e` runs in 20.74s. I've also run the PR/rebased with github actions. It got passed jena-fuseki-ui...

> complaining http: is not a command The good news is that it is not trying to run the internet. That might take some time.

We can't see the "read". Is the call`RDFPatchOps.readBinary`?