Andrea Frittoli comments

Results 380 comments of


                                            Andrea Frittoli

Fix for PipelineRuns getting stuck in the running state in the cluster

> > While implementing it, I was considering maybe we could always do a two-step timing out, this way we could avoid arbitrary thresholds. The first reconciliation would check `pr.HasTimedOut()`...

Fix no logs in stdout/stderr if uses stdoutConfig

@chengjoey thanks for this fix. As you pointed out, there is a test for this, which was already succeeding, which unfortunately means there is full coverage for this change -...

Fix no logs in stdout/stderr if uses stdoutConfig

@wlynch it would be nice if you could review this one since you changed this code last 🙏

add alpha feature gate check for param array indexing

Thanks @Yongxuanzhang for this PR. It seems to me that this PR and https://github.com/tektoncd/pipeline/pull/6103 have a dependency since this adds a new alpha flag related to indexing for array params...

task results not replaced with their values in childReferences

@pritidesai Just to confirm, is it expected for `when` conditions to be included in `childReferences` ?

TaskRun reports as successful when the pod was evicted

@drewbailey #5646 was merged and included in release v0.45.x - would you be able to verify if this issue could be closed then? Alternatively, would you be interested in designing...

Documentation guidelines

/remove-lifecycle rotten

Documentation guidelines

/reopen

Consider excluding third_party from ci jobs

Thanks @wlynch - IIRC we do have license testing in place as part of our CI to avoid things like AGPL.

Allow Task sidecars to be specified in Pipeline/PipelineRun

> @michaelsauter sorry 😓 So, as of today, your use case could be achieve by an early "in parallel" Task that provision the dependency you need, and a finally task...