afrind
afrind
Would still accept a PR for this but otherwise it's nonurgent.
Well 6 years on we were bound to take a look. I'm sorry it took so long, but you also need to sign the CLA for us to move forward....
Discussion here has died down. proxygen continues to be a leader in HTTP performance, though we admit tuning it for optimal perf can be a bit touchy. Feel free to...
I'm actually no longer able to reproduce the issue as described, but I'm not sure I like the new behavior. Once HTTPServer::stop is called, it will initiate drains on active...
We would like to do this, but we're blocked internally unfortunately.
Thanks for the PR. I hadn't envisioned websocket using any of the 'native' upgrade code so will need to spend some time looking at this.
You should be able to handle this upgrade in your handler without any changes to HTTP1xCodec. You should just need to verify the parameters and send the 101 Switching Protocols...
I think there are other mechanisms in proxygen that can handle websockets without these changes.
@AdamDailyMotion : you could locally modify the deps script to pin it to the folly/wangle head revisions. I realize it's not ideal.
Closing old issue. We're committed to the current system for now, but if this is still a pain point please reopen.