aframe icon indicating copy to clipboard operation
aframe copied to clipboard

should obb-collider component restore trackedObject3D's rotation instead of this.el.object3D's rotation in "updateBoundingBox" function?

Open zakaton opened this issue 5 months ago • 1 comments

in the obb-collider component's updateBoundingBox function, it stores the trackedObject3D's rotation, but restores it by assigning it to this.el.object3D's rotation instead of trackedObject3D

I propose changing this section around line 162:

      // Restore rotations.
      trackedObject3D.parent.matrixWorld.compose(auxPosition, auxQuaternion, auxScale);
      this.el.object3D.rotation.copy(auxEuler); // issue - assigns it to this.el.object3D.rotation

to

      // Restore rotations.
      trackedObject3D.parent.matrixWorld.compose(auxPosition, auxQuaternion, auxScale);
      trackedObject3D.rotation.copy(auxEuler); // fix - assigns it to trackedObject3D

zakaton avatar May 06 '25 17:05 zakaton