aframe icon indicating copy to clipboard operation
aframe copied to clipboard

Not up-to-date documentation

Open decima opened this issue 3 years ago • 3 comments

The example provided in the readme (given after) doesn't work out of the box. On glitch, the version used is 0.5 so it works but on 1.2 it does not.

  • A-Frame Version: 1.2
  • Platform / Device: google chrome
  • Reproducible Code Snippet or URL:
<html>
  <head>
    <script src="https://aframe.io/releases/1.2.0/aframe.min.js"></script>
    <script src="https://unpkg.com/[email protected]/dist/aframe-particle-system-component.min.js"></script>
    <script src="https://unpkg.com/aframe-extras.ocean@%5E3.5.x/dist/aframe-extras.ocean.min.js"></script>
    <script src="https://unpkg.com/[email protected]/dist/gradientsky.min.js"></script>
  </head>
  <body>
    <a-scene>
      <a-entity id="rain" particle-system="preset: rain; color: #24CAFF; particleCount: 5000"></a-entity>

      <a-entity id="sphere" geometry="primitive: sphere"
                material="color: #EFEFEF; shader: flat"
                position="0 0.15 -5"
                light="type: point; intensity: 5"
                animation="property: position; easing: easeInOutQuad; dir: alternate; dur: 1000; to: 0 -0.10 -5; loop: true"></a-entity>

      <a-entity id="ocean" ocean="density: 20; width: 50; depth: 50; speed: 4"
                material="color: #9CE3F9; opacity: 0.75; metalness: 0; roughness: 1"
                rotation="-90 0 0"></a-entity>

      <a-entity id="sky" geometry="primitive: sphere; radius: 5000"
                material="shader: gradient; topColor: 235 235 245; bottomColor: 185 185 210"
                scale="-1 1 1"></a-entity>

      <a-entity id="light" light="type: ambient; color: #888"></a-entity>
    </a-scene>
  </body>
</html>

decima avatar Nov 25 '21 20:11 decima

Probably ocean / particle system need to be fixed to account for the deprecation of THREE.Geometry

dmarcos avatar Nov 27 '21 03:11 dmarcos

PRs always welcome

dmarcos avatar Nov 27 '21 03:11 dmarcos

Additionally the link for aframe-gradient-sky is old and the new updated link is: https://cdn.rawgit.com/zcanter/aframe-gradient-sky/master/dist/gradientsky.min.js

Yash-Punia avatar Mar 01 '22 21:03 Yash-Punia