aframe
aframe copied to clipboard
aframevr
[stats] Faces limit seems low.
Someone pointed out in Slack that the default <a-sky/> element already exceeds the faces limit:
Maybe the sphere resolution should be lowered, maybe not, but regardless I think the stats threshold seems too low. Seems like the limit should be at least maxVertices / 3?
Is there some validity to it? Ideally even though it's a bit more work and we should add more support, people would use cubemaps to get it down to 6 faces?
I don't think there's any ~validity~ consistency to it — if 12000 vertices is OK, then 12000 / 3 faces should be OK too.
Could someone point me to where this limit is defined? Digging around and can't seem to find it. The faces limit is really not consistent with the vertex limit here.
Also — perhaps the stats component should include a link to our performance best practices doc, where we'd explain what Calls means etc.?
is it here that it sets the face limit? - https://github.com/aframevr/aframe/blob/master/vendor/rStats.extras.js#L121
Little rember for this issue, should be easy to fix: The statistics currently give the impression that AFrame is not efficient. And that is not true.
The current limit on triangles is set very low to the point that it's effectively useless. I'd suggest removing rather than increasing the limit. Since A-Frame runs on a wide array of devices there isn't any single value that makes sense.
As a general rule of thumb I'd rather give people the right tools to verify that they're hitting their frame timings. When that isn't the case they should delve into the stats and start profiling to find their bottleneck. Having the stats show a 'red' number for triangles probably leads many down the wrong path when trying to optimize their experience.
I've thought about it and I completely agree. The only interesting line is the fps/raf value. Maybe this is the only value that should be displayed in red when it is below 30 fps like it is now?