Fix TextureWidget componentDidUpdate to not crash React UI on aframe 1.6.0

Open vincentfretin opened this issue 1 year ago • 3 comments

This closes #722

Jun 16 '24 09:06 vincentfretin

Note this PR is okay to be merged, it doesn't crash anymore when you select an entity with a texture, but there is still an issue of changing the texture that's being discussed in #722

Jun 26 '24 08:06 vincentfretin

Okay, I just verified with aframe master by copying a build manually, the issue of changing the texture on the cube is definitely fixed with both this change and the changes from https://github.com/aframevr/aframe/pull/5544 You can merge @dmarcos

Jun 26 '24 12:06 vincentfretin

I'm confirming https://github.com/aframevr/aframe/pull/5549 fixes the issue of removing the texture on the cube. @dmarcos can you please merge?

Jun 28 '24 07:06 vincentfretin

Thanks!

Jul 01 '24 14:07 dmarcos