aframe-inspector icon indicating copy to clipboard operation
aframe-inspector copied to clipboard

Published 20 hours ago • verified publisher icon aframevr

Fix inspector toggle on US international keyboards

Open svenkonings opened this issue 4 years ago • 1 comments

Fixes issue #595 See also issue aframevr/aframe#4089

On US international keyboards Ctrl + Alt are combined into AltGraph. When this happens Ctrl and Alt are registered as unpressed, breaking the toggle expression

This is fixed by adding an additional clause for the AltGraph combination.

svenkonings avatar Mar 07 '20 22:03 svenkonings

The keyboard shortcut in aframe-inspector should also be updated now aframevr/aframe#4516 has been merged.

svenkonings avatar Feb 14 '21 12:02 svenkonings

@dmarcos you should really merge this one. It will allow to use the same shortcut to close the inspector. On a French keyboard, AltGr is a real key. I can currently open the inspector with Ctrl+Alt+i or AltGr+i (shortcut defined in the aframe inspector component). But I can only close the inspector with Ctrl+Alt+i (the shortcut defined here in aframe-inspector). If you merge this, I will be able to close with AltGr+i as well.

vincentfretin avatar Oct 10 '22 17:10 vincentfretin

@dmarcos the fix of this PR is included in #647 after prettier reformatting.

vincentfretin avatar Dec 02 '22 13:12 vincentfretin

@vincentfretin Thanks. I can close. For https://github.com/aframevr/aframe-inspector/pull/647 might be good to break into separate PRs. It seems it's already including a lot of stuff

Closed in favor of https://github.com/aframevr/aframe-inspector/pull/647

dmarcos avatar Dec 06 '22 02:12 dmarcos