aframe-inspector icon indicating copy to clipboard operation
aframe-inspector copied to clipboard

fix prettier eslint

Open lazychip opened this issue 5 years ago • 2 comments

When i cloned the repo and started to look the code eslint is so messed up and all those end lines with my eslint on 😖.
I have added prettier-eslint to fix the code and husky hooks on precommit to future save the code.

lazychip avatar Mar 09 '19 08:03 lazychip

I just have the codebase on Prettier. I don't think it matters much to use Prettier vs. ESLint, so it's okay to just keep it on Prettier? More common in React/JSX codebases.

ngokevin avatar Mar 10 '19 03:03 ngokevin

Personally i like eslint and I think eslint, prettier codebase is more common in React/JSX. Its okay to keep the codebase on Prettier but i think if you want to continue the codebase on prettier only then remove the eslint config from the codebase to avoid the confusion for the contributors.

lazychip avatar Mar 12 '19 10:03 lazychip

@dmarcos Please close this one. All eslint errors are fixed by #639 and the prettier reformat will be done in #647

vincentfretin avatar Dec 02 '22 13:12 vincentfretin

Close in favor of https://github.com/aframevr/aframe-inspector/pull/647

dmarcos avatar Dec 06 '22 02:12 dmarcos