a-painter icon indicating copy to clipboard operation
a-painter copied to clipboard

Why having a separate options objects on `registerBrush`

Open dmarcos opened this issue 9 years ago • 1 comments

If there's not a good reason I would consolidate everything on a single object

dmarcos avatar Sep 08 '16 03:09 dmarcos

At first I thought about having the options + name as a single object, something like:

registerBrush({name: 'flat', spacing: 0.2}, definition);

But, following the registerXXX from AFRAME I changed it to include just the name as the first parameter. Another option could be to include the options themselves in the definition but as they're not really part of the definition, but options to properly setup the brush engine for that brush, I don't feel like a good idea to "pollute" the definition. Which options do you like more?

fernandojsg avatar Sep 08 '16 09:09 fernandojsg