sabnzbd-knockstrap icon indicating copy to clipboard operation
sabnzbd-knockstrap copied to clipboard

Pause for XX minutes

Open cdavin opened this issue 11 years ago • 19 comments

Hi,

Is there any way to add the pause for X minutes into this skin? I use this all the time otherwise I forgot that it was paused.

Thanks for creating a such a great skin.

cdavin avatar Jul 19 '13 17:07 cdavin

Yes I've been meaning to put this in.

aforty avatar Jul 22 '13 13:07 aforty

I have a branch for this feature. Once it's ready to be tested and integrated, I'll submit a pull request.

btsuhako avatar Sep 03 '13 06:09 btsuhako

Awesome, that would be great! I've been swamped with work lately :-1:

aforty avatar Sep 03 '13 13:09 aforty

@aforty do you have a list of issues/missing features? Perhaps it would be worth creating an issue for each to make it clearer what functionality you'd like adding..

I was going to swap to Bootstrap v3 but @btsuhako has already got that going (#7).

BeingTomGreen avatar Sep 03 '13 13:09 BeingTomGreen

I have a list and will import as issues when I get the chance, hopefully that's sooner rather than later.

aforty avatar Sep 03 '13 17:09 aforty

Added: #10 and #11

I've wanted to do #11 for the longest time now, would still prefer to do this myself when I get some time. Otherwise, #7 requires more testing and some fixes.

aforty avatar Sep 04 '13 14:09 aforty

I've almost worked out this feature in a branch I'll submit as a pull request. You enter a whole number in the pause field, then it gets submitted to SABnzbd. The time left is then bound to the server value. Here's a sneaky preview:

image

edit: There's an info banner at the top of the main screen that appears and shows the pause time remaining.

btsuhako avatar Sep 04 '13 15:09 btsuhako

Neat! Might be more useful if the option to pause is easy to activate right from the queue. I'm picturing a small "pause" icon (icon-pause) that when hovered reveals a dropdown of pre-determined pause-time values (I would skip the option to input time manually). Once a pause is active then display the time the same way you do but have a "Cancel" option within the blue bar.

This stuff should be pretty easy to change after though if you want to just keep banging away on the path you're on.

aforty avatar Sep 04 '13 15:09 aforty

Have to agree with a small pause button!

BeingTomGreen avatar Sep 04 '13 15:09 BeingTomGreen

I also thought about a dropdown, and it makes sense to put it in the queue section. Initially for this feature, I thought that the options panel could house the option. I don't know how the hover would work on mobile devices. And I'm not sure if BS3 has a built-in way to do hover menus, but it's doable to use the click/tap to display the dropdown.

I like the idea of a button group or menu with pre-populated pause times. On the mac app, there's 10, 20, 30, 40, 50, and 60 minutes. Does that sound good?

btsuhako avatar Sep 04 '13 16:09 btsuhako

I think pause should be an actual button because I use that a lot, but things like priority, category and pause for a set time should be dropdowns.

BeingTomGreen avatar Sep 04 '13 16:09 BeingTomGreen

Yeah good thinking on mobile.

Let's think about this logically. There is already a Pause button on the top nav. Let's make the Pause button in the top-nav a split-button dropdown where the main button area pauses the queue indefinitely. Then if the dropdown area is clicked there should be the following options: 10, 20, 30 minutes, 1 hour, 3 hours, 5 hours and indefinitely. Indefinitely just acts the same as a main pause already does.

Pausing a queue in progress already displays next to the Queue section, so when timed-paused it should just show the same but with a countdown for when it resumes and an option to resume right away (I believe this already exists).

Easy peasy.

aforty avatar Sep 04 '13 16:09 aforty

The split button is a fantastic idea! I can re-work what I've done, and then submit a pull request.

btsuhako avatar Sep 04 '13 16:09 btsuhako

Love the split button to control the whole queue, but I quite often pause an individual item in the queue, how would I manage this?

BeingTomGreen avatar Sep 04 '13 16:09 BeingTomGreen

How do you manage that now? I wasn't aware that a per-queue-item timed-pause was even an option in SABnzbd.

You can still pause individual items the same as you can now but timed-pause is the whole queue or nothing at all.

aforty avatar Sep 04 '13 16:09 aforty

Ahh, my bad I was confusing priority - it's been a long day!

As long as you can still pause single items all is good :)

BeingTomGreen avatar Sep 04 '13 17:09 BeingTomGreen

image

I think I've got it all built out. Pull request is in the works!

btsuhako avatar Sep 05 '13 21:09 btsuhako

Neat!

Quick thought if you want to fix before pull request: When paused (regardless of timed or indefinite) then remove/disable the dropdown and just have the option to Resume. When in active (resumed) state show those options + 'Indefinitely' (which acts like a regular pause does).

Be sure to target the Release-0.6 branch for your pull request.

aforty avatar Sep 05 '13 21:09 aforty

Great idea. Done!

btsuhako avatar Sep 05 '13 21:09 btsuhako