Anna Filina
Anna Filina
@jrfnl Documented the limitations you suggested. See "Syntax Variations" section for what should be sniffable.
@jrfnl For this research, I went into more detail for what it means to be "non-numeric".
@jrfnl See "Top 2000" section. The occurrences where I found the deprecated usage would be hard to detect with PHPCompatibility. Same as with Phar: https://github.com/PHPCompatibility/PHPCompatibility/issues/1980#issuecomment-3475306039
@jrfnl Hopefully I managed to improve the quality of syntax variation in the research (I'll circle back to the tickets where more research is needed).
@jrfnl This function is seldom used with the deprecated signature (`Top 2000 Packages`). It's also hard to sniff as it relies on types (`Syntax Variations`). You could basically swap the...
Upon a closer look, even though it might logically make sense to look at the second argument because integers are easier to infer, the php-src commit actually checks for the...
I don't have stats beyond the public packages, but this one will probably be in proprietary code. I've never seen it in the wild personally. I'm fine with detecting int...
@jrfnl Anything else you need from me on this ticket before classifying it?
@jrfnl I'm changing the formula a bit by focusing "Detection" sections on our actual target (things that observably changed), and move all the variations, false positives, etc to "Syntax Variations...
@jrfnl Please postpone the review of the above findings until I do a related RFC, which might have an impact on how we approach this one. I'll let you know.