main
main copied to clipboard
remove email format validation on API sync
The ActionNetwork database contains strings in the email field which are not valid email addresses. When we try to validate them during the sync process we get errors like
`Error message ActiveRecord::RecordInvalid: Validation failed: Email addresses address '[email protected]' does not match (?i-mx:\A([^@\s]+)@((?:[-a-z0-9]+.)+[a-z]{2,})\z)
Stack trace (show Rails)
/app/app/models/api/action_network/import.rb: 92:in tap' /app/app/models/api/action_network/import.rb: 92:in create_single_resource'
/app/app/models/api/action_network/person.rb: 46:in after_import' /app/app/models/api/action_network/ person.rb: 8:in block in import!'
/app/app/models/api/action_network/
import.rb: 44:in request_single_resource_from_action_network' /app/app/models/api/action_network/ person.rb: 7:in import!'
/app/app/models/api/action_network/taggings.rb: 44:in find_or_import_person' /app/app/models/api/action_network/taggings.rb: 27:in associate_person'
/app/app/models/api/action_network/taggings.rb: 16:in block in import!' /app/app/models/api/action_network/taggings.rb: 16:in each'
/app/app/models/api/action_network/taggings.rb: 16:in import!' /app/app/models/api/action_network/tags.rb: 23:in block in import!'
/app/app/models/api/action_network/tags.rb: 19:in each' /app/app/models/api/action_network/tags.rb: 19:in import!'
/app/app/models/group.rb: 48:in import_tags' /app/app/models/group.rb: 64:in sync_with_action_network'
…or/bundle/ruby/2.3.0/gems/rake-12.0.0/lib/rake/task.rb: 250:in block in execute' …or/bundle/ruby/2.3.0/gems/rake-12.0.0/lib/rake/task.rb: 250:in each'
…or/bundle/ruby/2.3.0/gems/rake-12.0.0/lib/rake/task.rb: 250:in execute' …or/bundle/ruby/2.3.0/gems/rake-12.0.0/lib/rake/task.rb: 194:in block in invoke_with_call_chain'
/app/vendor/ruby-2.3.3/lib/ruby/2.3.0/monitor.rb: 214:in mon_synchronize' …or/bundle/ruby/2.3.0/gems/rake-12.0.0/lib/rake/task.rb: 187:in invoke_with_call_chain'
…or/bundle/ruby/2.3.0/gems/rake-12.0.0/lib/rake/task.rb: 180:in invoke' …le/ruby/2.3.0/gems/rake-12.0.0/lib/rake/application.rb: 152:in invoke_task'
…le/ruby/2.3.0/gems/rake-12.0.0/lib/rake/application.rb: 108:in block (2 levels) in top_level' …le/ruby/2.3.0/gems/rake-12.0.0/lib/rake/application.rb: 108:in each'
…le/ruby/2.3.0/gems/rake-12.0.0/lib/rake/application.rb: 108:in block in top_level' …le/ruby/2.3.0/gems/rake-12.0.0/lib/rake/application.rb: 117:in run_with_threads'
…le/ruby/2.3.0/gems/rake-12.0.0/lib/rake/application.rb: 102:in top_level' …le/ruby/2.3.0/gems/rake-12.0.0/lib/rake/application.rb: 80:in block in run'
…le/ruby/2.3.0/gems/rake-12.0.0/lib/rake/application.rb: 178:in standard_exception_handling' …le/ruby/2.3.0/gems/rake-12.0.0/lib/rake/application.rb: 77:in run'
…ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/cli/exec.rb: 74:in load' …ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/cli/exec.rb: 74:in kernel_load'
…ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/cli/exec.rb: 27:in run' …ndle/ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/cli.rb: 360:in exec'
…ler-1.15.2/lib/bundler/vendor/thor/lib/thor/command.rb: 27:in run' …-1.15.2/lib/bundler/vendor/thor/lib/thor/invocation.rb: 126:in invoke_command'
…ems/bundler-1.15.2/lib/bundler/vendor/thor/lib/thor.rb: 369:in dispatch' …ndle/ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/cli.rb: 20:in dispatch'
…undler-1.15.2/lib/bundler/vendor/thor/lib/thor/base.rb: 444:in start' …ndle/ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/cli.rb: 10:in start'
…3.0/gems/bundler-1.15.2/lib/bundler/
friendly_errors.rb: 121:in with_friendly_errors'
We don't want to break when we sync faulty data from someone else via the API. We need to remove this validation.
@Matt-Holland @rabble I started to work on this issue, let me know if you are agree or if there is a better ticket for me.