matlab-formatter-vscode icon indicating copy to clipboard operation
matlab-formatter-vscode copied to clipboard

[Feature Request] Add support for Octave in Extension Manifest

Open nonnullish opened this issue 1 year ago • 1 comments

Hello,

First of all - thank you so much for creating this extension. It helped me enormously during my university years and I am very grateful for the work you put into it.

At that time I could not make it work with Octave, so I created a fork and made a change in the extension manifest so that VS Code would recognize it and use it with Octave.

Now I would have made a pull request to your repository instead of doing it the way I did, but at that time I thought the distinction was intentional.

I would like to retire that extension and allow the people that use it to move to your original extension.

I do not have any way to test it now, but I think the following changes could be made in package.json:

...
"categories": [
  "Other",
+ "Formatters"
],
"keywords": [
  "matlab",
+ "octave"
],
"activationEvents": [
  "onLanguage:matlab",
+ "onLanguage:octave"
],
...
"languages": [
    {
        "id": "matlab",
        "aliases": [
            "MATLAB"
        ]
    },
+   {
+       "id": "octave",
+       "aliases": [
+           "OCTAVE",
+           "Octave"
+       ]
+   }
],
...

Thank you once again for creating this formatter.

nonnullish avatar Oct 21 '23 18:10 nonnullish

Interesting... I also use octave myself instead of matlab. Always interpret *.m as MATLAB in VSCode, so I wasn't even aware that this might be an issue ;) I'll update the package.json.

affenwiesel avatar Oct 21 '23 19:10 affenwiesel