bloxy icon indicating copy to clipboard operation
bloxy copied to clipboard

Published 20 hours ago • verified publisher icon affenity

Bloxy Version 6

Open Syrilai opened this issue 3 years ago • 9 comments

This PR (and branch) updates bloxy to version 6.

No information yet to this other than it will fix a lot of problems.

To-Do:

  • [ ] Update APIs

APIs:

  • [ ] AccountInformation
  • [x] AccountSettings
  • [x] AdConfiguration
  • [x] AssetDelivery
  • [x] Auth
  • [x] Avatar
  • [x] Badges
  • [x] Base
  • [x] Billing
  • [x] Catalog
  • [x] Chat
  • [x] Contacts
  • [x] Data
  • [x] Develop
  • [x] Economy
  • [x] EconomyCreatorStats
  • [x] EngagementPayouts
  • [x] Followings
  • [x] Friends
  • [x] GameInternationalization
  • [x] Games
  • [x] General
  • [x] Groups
  • [x] Inventory
  • [x] ItemConfiguration
  • [x] Locale
  • [x] Metrics
  • [x] Notifications
  • [x] Other
  • [x] PremiumFeatures
  • [x] Presence
  • [x] PrivateMessages
  • [x] Publish
  • [x] Thumbnails
  • [x] TranslationRoles
  • [x] TwoStepVerification
  • [x] Users

Critical Changes

  • CaptchaAPI was removed
  • AdsAPI was removed
  • TradesAPI was removed

Syrilai avatar Jan 07 '22 05:01 Syrilai

Commented everything I done on my fork (+ #279 & #280)

guidojw avatar Jan 08 '22 15:01 guidojw

Is there a reason why you didn't choose to use export * from './path' syntax in index.ts?

guidojw avatar Jan 08 '22 15:01 guidojw

✅ Sider has resolved the errors or warnings via the commit ea5281d! See the analysis result for details.

You can turn off such notifications if unnecessary.

ghost avatar Jan 08 '22 21:01 ghost

Commented everything I done on my fork (+ #279 & #280)

@guidojw Guessing because I worked the entire night, and I did the imports at around 7 am. Should be changed with the next commit that I have on hand, just need to update all typings in the apis first.

Syrilai avatar Jan 08 '22 21:01 Syrilai

compiled typescript output should stay in gitignore since it's not source files and can just be recompiled

jaydns avatar Jan 20 '22 04:01 jaydns

compiled typescript output should stay in gitignore since it's not source files and can just be recompiled

This allows to install the branch with npm and will only stay for a bit

Syrilai avatar Jan 20 '22 13:01 Syrilai

After some digging, I finally found the cause of the error where X-CSRF token refreshing doesn't always correctly work:

The status message handler lowercases the received status message before comparing it to the set allowed/disallowed status messages. The set token validation error status message includes uppercase letters so this fails: https://github.com/Visualizememe/bloxy/blob/ea5281d6e99013bec5a57cc886bb85fa5ea861c4/src/controllers/rest/request/prepare.ts#L50

A good fix would be lowercasing statusMessage here https://github.com/Visualizememe/bloxy/blob/ea5281d6e99013bec5a57cc886bb85fa5ea861c4/src/controllers/rest/response/handlers/validStatusMessage.ts#L18 and here https://github.com/Visualizememe/bloxy/blob/ea5281d6e99013bec5a57cc886bb85fa5ea861c4/src/controllers/rest/response/handlers/validStatusMessage.ts#L22

Although not really relevant for this PR, it seems like a good fix to include here.

guidojw avatar Feb 27 '22 02:02 guidojw

Also what's the timeline on this? ~~I see the bloxyjs/core repository, is that gonna be the new home for this project?~~ I read the linked issue, and seems like this is already on there 👍🏿

guidojw avatar Feb 27 '22 02:02 guidojw

Also what's the timeline on this? ~I see the bloxyjs/core repository, is that gonna be the new home for this project?~ I read the linked issue, and seems like this is already on there 👍🏿

Yeah, bloxyjs/core is the new repository, since Martini unfortunately still did not manage to transfer the repository

Syrilai avatar Feb 27 '22 04:02 Syrilai