PhotoFlow icon indicating copy to clipboard operation
PhotoFlow copied to clipboard

FindLenses override removed in lensfun 0.3.95

Open JohnAZoidberg opened this issue 5 years ago • 3 comments

The override with two arguments was removed in https://github.com/lensfun/lensfun/commit/df8318c6979674ee968a52b4eb0c7ec1b2308e61 But this project is still using it, e.g. in https://github.com/aferrero2707/PhotoFlow/blob/stable/src/rt/rtengine/rtlensfun.cc#L472

This makes the project fail to build when not using the vendored lensfun lib.

JohnAZoidberg avatar Sep 13 '19 13:09 JohnAZoidberg

Thanks a lot for pointing this out, will look into that as soon as possible.

aferrero2707 avatar Sep 15 '19 18:09 aferrero2707

One solution is to use rawtherapee version. At least it permits to build with 0.3.95 version of MSYS2 or a self built lensfun from lensfun git.

gaaned92 avatar Sep 22 '19 15:09 gaaned92

@JohnAZoidberg I have committed a fix in the stable branch.

@gaaned92 the photoflow code already inherits from RT, but I have an additional piece that handles cases where the EXIF lens name does not match exactly the LF database. That's where the removed function was called...

aferrero2707 avatar Oct 19 '19 08:10 aferrero2707