Andrea Fercia

Results 255 comments of Andrea Fercia

I'd be totally in favor of a shared component to reduce duplication and have more consistency. Worth noting the Inserter should not use an ARIA tabs interface when it shows...

Some of the relevant files to be checked: ``` packages/block-editor/src/components/link-control/index.js packages/block-editor/src/components/link-control/search-input.js packages/block-library/src/navigation-link/edit.js packages/block-library/src/navigation-submenu/edit.js ```

> I think what we have in https://github.com/WordPress/gutenberg/pull/60116 is sufficient I don't think it's sufficient. - in https://github.com/WordPress/gutenberg/pull/60047#discussion_r1535522540 I suggested to just use the terminology WordPress always used: 'Link text'....

Yep, that 'Navigation Label' in the classic menus is pretty old. It's inconsistent with custom links and also a little weird to translate. Also, it shouldn't be title case. Not...

@Niyatijain-9 thanks for willing to work on this. You don't need to be assigned to an issue to work and submit a PR.

I think https://github.com/WordPress/gutenberg/pull/60116 took care of this but failed to properly reference this issue to close it. Noting that in a following PR https://github.com/WordPress/gutenberg/pull/65458 the label of the LinkControl was...

To me, what matters most is consistency. first Fonts are gouped by source in the modal dialog. As such, it's consistent, and expected, that they are grouped in the panel...

> I'd tend to agree with Rich: the delineation over source makes sense in the font library itself (the modal), but the inspector context is the context of the document,...

> One shows the fonts available on your site (I don't think "active" is a necessary distinction) while the other shows all fonts I could agree to make these two...

> I'm confident visible fonts in this list imply that they are "active" font. The same as any other UI we have. Like colors for example, if it's listed, it's...