Aidan Feldman comments

Results 219 comments of


                                            Aidan Feldman

Avoiding to checkchanges on sub Backbone.Models/Collections

Hmmmmm. The code looks good (thanks for all the documentation), but I'm wondering if there are other implications for why we _wouldn't_ want to do this. If the object is...

Do not confuse Model instance with plain objects

Thanks or sending this! Would you mind adding a (previously-failing) test to verify that the change works?

handle array paths when checking for changes

Looks good! Mind adding a test?

change event not triggered when setting an object that contains an array

Hmm, interesting. http://jsbin.com/fezuyerire/2/edit?js,console Seems like a bug, unfortunately :confused: Arrays aren't a problem when they are top-level properties: http://jsbin.com/fegexe/1/edit?js,console I can't look into this until this weekend, but would more...

change event not triggered when setting an object that contains an array

Ohhhh, gotcha, it's the _setting_ with an array. Bug!

Cannot set property of nested array by index dynamically

Figure it out?

Working on Node Support

Cool, thanks! I'm going to try to get the rewrite done this weekend, and will revisit this then.

Add some tests for change()

Cool, thanks! Not sure when I can get to the fix, but a pull request is welcome from anyone listening :-)

Infinite recursion

Hmm, I wonder why this wasn't fixed by #80... mind submitting a failing test (that preferably doesn't involve `window`)?

Setting data inside an array fires an add event on the parent array

Hmm, yep, `add()` is using `set()` under the hood, but should probably be checking `isNewValue` (or something) before firing that event. Looking into it now.