afdesk

Results 365 comments of afdesk

@pablogalegoc thanks for your comment. now `Trivy` supports only binaries built by Go. the check is here: https://github.com/aquasecurity/trivy/blob/7699153c6679dd6eaf377700b5f587cb1741368d/pkg/fanal/analyzer/language/golang/binary/binary.go#L42-L45 this behavior may be changed later.

@AndrewCharlesHay thanks for your PR. LGTM, but i'd like to check it more.

sorry for waiting. it seems the updated asff template builds a correct result, so approved

oh, i have an idea. maybe should we write an integration test for it?

> @afdesk Is there documentation on writing integration tests? I haven't looked to deep into it but I'm not sure how they work unfortunately, there is no any docs. but...

@AndrewCharlesHay if it's ok for you, i can update the integration test data

> > @AndrewCharlesHay if it's ok for you, i can update the integration test data > > That would be great! I honestly didn't really want to smile yes, sure....

> @afdesk Did you have a chance to add tests? yes, almost done

I've added a test and a golder file for it. @AndrewCharlesHay @knqyf263 could you take a look?

@AndrewCharlesHay thank you for the contribution