Why do we have src/Colors.purs

[jez]

When I compile purescript-d3v4 on psc 0.10.6 I get this error in src/Colors.purs:

[1/4 UnusedImport] src/Colors.purs:3:1

  3  import Color (rgb, fromHexString, toHexString)
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  The import of module Color is redundant

(I don't get this error on 0.9.x, but I'd like to use 0.10.x so that I can include it in another project.)

But the body of src/Colors.purs is empty, and just appears to be wrapping purescript-colors. Is there any reason why we want to explicitly wrap these three functions?

Also as far as I can tell, D3.Colors doesn't get imported in the project or the examples.

[afcondon]

I think i can make some time this morning to have a look at this, it would be good to have it compile on 0.10 for sure.

I'd say that's just a warning that became an error in later version of psc...but i'll look later and see.

[jez]

I'd say that's just a warning that became an error in later version of psc...but i'll look later and see.

That's my guess as well.

it would be good to have it compile on 0.10 for sure.

I actually have it compiling over in my fork. I can even install it using bower (with a [email protected]: URL), and I'm using it for a school project.

I was going to wait to send the PR until I'd finished my project and confirmed that everything was working as intended, but you're free to check it out now if you want.

[afcondon]

Oh, that's nice to hear. I'm happy to take PR now or later either way.