kirby-blade icon indicating copy to clipboard operation
kirby-blade copied to clipboard

Option `doMakeSameDomainsLinksRelative` requires array, not boolean

Open S1SYPHOS opened this issue 2 years ago • 1 comments

Hey there, when looking at voku/htmlmin options, it's clear that doMakeSameDomainsLinksRelative is the only option receiving an array (not a boolean like the others). Therefore, it's logical that passing true / false inside config.php throws a TypeError:

Screenshot from 2022-06-25 10-42-51

I'd suggest passing every option 'as-is', or at least check for $option == 'doMakeSameDomainsLinksRelative' :confused:

Cheers, S1SYPHOS

S1SYPHOS avatar Jun 25 '22 08:06 S1SYPHOS

FYI I opened an issue over at voku/htmlmin because I find the naming scheme somewhat inconsistent.

S1SYPHOS avatar Jun 25 '22 09:06 S1SYPHOS