Kirby-Tabs-Field
Kirby-Tabs-Field copied to clipboard
Within a structure, tab doesn't switch to show submission error
When a user submits a form with error, this plugin switches to the offending tab so they can see where their error is located.
Unfortunately, this behaviour doesn't happen within a structure field.
I added a pull request with this functionality. Could you test this @samnabi? Thanks a lot.
The tab now switches properly within a structure modal, but it causes a Javascript bug that freezes the browser.
A script on this page may be busy, or it may have stopped responding. You can stop the script now, open the script in the debugger, or let the script continue.
Script: http://www.shopkit.local/panel…s/js/dist/panel.min.js?v=2.4.1:4
Hard to debug the issue here, since line 4 of the minified JS file is huge.
I think this happens when having another plugin installed as I still can't reproduce it. Could you try disabling your installed plugins? That way I can probably debug it.
Looks like this error is only present on Firefox in OS X. Chrome and Safari seem to work fine.
Steps to replicate:
- Download Kirby Starterkit
- Download Tabs field at commit 8f86baa and put in in the
site/fields
folder - Replace blog.yml blueprint with this one: blog.yml.zip
- Navigate to
localhost/panel/pages/blog/edit
- Add a new structure item
- Leave
Title
blank and switch toTab Two
- Put some content in the textarea and try to save the structure item
- The modal switches back to the first tab, highlights the required
Title
field, and then chokes on a JavaScript error