pHash icon indicating copy to clipboard operation
pHash copied to clipboard

Build instructions need updating

Open timstableford opened this issue 6 years ago • 6 comments

The build instructions in INSTALL still reference automake rather than CMake

timstableford avatar Oct 06 '19 17:10 timstableford

Indeed. I am trying to compile the Java bindings and there are no instructions for doing that. The README says ./configure --enable-java, but there is no configure script except in the bindings/php directory.

mcmasjc3 avatar Jul 07 '21 21:07 mcmasjc3

A little late, but still better than never. Please review and approve my fix for this issue. Thank you.

obushnell avatar Oct 14 '22 01:10 obushnell

This project is no longer being maintained. But here is a new version. It is not just a fork, but a complete redo.

https://github.com/starkdg/phash

starkdg avatar Oct 14 '22 14:10 starkdg

And yet, this project has newer commits then yours. How does that work?

obushnell avatar Oct 14 '22 22:10 obushnell

@bushnell , I think you'll admit those are fairly minor commits. I just cleaned it up a bit and added some unit tests. I would have added it here, but the owner doesn't want to work on it anymore. Not trying to bad mouth the project here, just letting you know.

starkdg avatar Oct 15 '22 01:10 starkdg

I have added a link to the new repo along with a message that this repo is no longer maintained to my pull request. Please approve it and officially indicate your position.

obushnell avatar Oct 15 '22 19:10 obushnell

@obushnell I apologize. I thought you owned the repos.

No need to include a link or officially declare it dead. I thought I was just stating the obvious, but people can decide for themselves which one suits them better. I was merely supplying a link to a version that I had cleaned up and added tests. I worked with the owner on this off and on, on various projects going back 10 years, but he apparently does not have the time or inclination to do much with it, but also does not want to give up the account. I have no idea if he is even around anymore. Not that there is anything more to do with it, because there are better solutions now. (For image perceptual hashes, see the phashml project under my page for a more robust image hash).

If you want to talk more, you are welcome to message me on telegram @starkdg

starkdg avatar Oct 15 '22 20:10 starkdg