pHash icon indicating copy to clipboard operation
pHash copied to clipboard

Fix Travis CI build for linux

Open bitnot opened this issue 3 years ago • 5 comments

Follow up on 99bcd4d Sets the LIBDIR variable to lib.

Failing build Passing build

bitnot avatar Oct 12 '21 15:10 bitnot

@aetilius, @G10h4ck could you check if this makes sense?

Another note: it seems that Travis is having some trouble running the builds from the main repo:

Screenshot 2021-10-12 at 18 31 58 s

bitnot avatar Oct 12 '21 15:10 bitnot

Thanks @bitnot. I believe the travis issue is fixed now, are you able to confirm?

aetilius avatar Oct 12 '21 15:10 aetilius

The latest change i committed and is already merged in master should fix this already more automatically so this extra change should be not necessary

G10h4ck avatar Oct 15 '21 09:10 G10h4ck

Thanks @bitnot. I believe the travis issue is fixed now, are you able to confirm?

Hey @aetilius. Builds seems to be working now - see #30

~I think you would have to push a new commit to make sure Travis CI can start the build.~ ~You can see the past builds failed to start here: https://app.travis-ci.com/github/aetilius/pHash/requests~

~And just to make sure we are on the same page, the issue I am referring to is "Could not authorize build request for aetilius/pHash". You might want to check how you Travis CI plan is configured.~

The latest change i committed and is already merged in master should fix this already more automatically so this extra change should be not necessary

@G10h4ck , The purpose of this PR is to fix a very specific environment - Travis CI bionic linux. I am not familiar with CMake or building C on Linux, so forgive me if I am suggesting nonsense, but it seems to me that Travis CI does not initialize the LIBDIR properly.

On top of that there is (was?) an issue in general preventing builds in the original aetilius/pHash to start (see above). It works fine in my fork however.

bitnot avatar Oct 16 '21 06:10 bitnot

Ok for me to merge this PR

G10h4ck avatar Oct 18 '21 12:10 G10h4ck