aether-app icon indicating copy to clipboard operation
aether-app copied to clipboard

fix inconsistent vendoring

Open milahu opened this issue 3 years ago • 2 comments

cd aether-core; go mod vendor

is needed to build from source on nixos

error was:

Building subPackage ./aether/backend
go: inconsistent vendoring in /build/aether-core:
        github.com/golang/[email protected]: is explicitly required in go.mod, but vendor/modules.txt indicates github.com/golang/[email protected]
        golang.org/x/[email protected]: is explicitly required in go.mod, but vendor/modules.txt indicates golang.org/x/[email protected]
        golang.org/x/[email protected]: is explicitly required in go.mod, but vendor/modules.txt indicates golang.org/x/[email protected]
        golang.org/x/[email protected]: is explicitly required in go.mod, but vendor/modules.txt indicates golang.org/x/[email protected]
        golang.org/x/[email protected]: is explicitly required in go.mod, but vendor/modules.txt indicates golang.org/x/[email protected]

        To ignore the vendor directory, use -mod=readonly or -mod=mod.
        To sync the vendor directory, run:
                go mod vendor

edit: now tests are failing

done: unable to open database file
STACK TRACE
aether-core/aether/services/logging/logging.go:73
aether-core/aether/backend/cmd/root.go:236
aether-core/aether/backend/eventhorizon_test/eventhorizon_test.go:41
_testmain.go:61
runtime/proc.go:225

2021/08/26 16:30:30 unable to open database file
FAIL    aether-core/aether/backend/eventhorizon

problem: in the nix build env, the test cannot create $HOME/.config/Air Labs/A-UnitTest/backend/AetherDB.db which on nixos is /homeless-shelter/.config/Air Labs/A-UnitTest/backend/AetherDB.db and sqlite fails on mkdir of /homeless-shelter -> set $HOME to /tmp

i broke some of the eventhorizon tests

=== RUN   TestPostInsert_Success
    eventhorizon_test.go:168: Insertion failed, not all data requested has been inserted. expected 1000 - actual 0
--- FAIL: TestPostInsert_Success (0.35s)

=== RUN   TestPruneDB_WithinLocalMemory_Success
    eventhorizon_test.go:202: Event horizon accidentally cleared data that was within the network memory. expected 1000 - actual 0
--- FAIL: TestPruneDB_WithinLocalMemory_Success (0.37s)

=== RUN   TestPruneDB_WithinLocalMemory_TooBigDb_Success
    eventhorizon_test.go:228: Event horizon accidentally cleared data that was within the network memory. expected 2000 - actual 0
--- FAIL: TestPruneDB_WithinLocalMemory_TooBigDb_Success (1.37s)

=== RUN   TestPruneDB_ScaledModeGetsEnabled_Success
    eventhorizon_test.go:284: Event horizon did not stop deleting from within the network head when it should have. expected 1000 - actual 0
--- FAIL: TestPruneDB_ScaledModeGetsEnabled_Success (0.49s)

=== RUN   TestPruneDB_ScaledModeManuallySet_Success
    eventhorizon_test.go:305: Event horizon did not stop deleting from within the network head when it should have. expected 1000 - actual 0
--- FAIL: TestPruneDB_ScaledModeManuallySet_Success (0.42s)

FAIL
FAIL    aether-core/aether/backend/eventhorizon 3.494s
FAIL

milahu avatar Aug 26 '21 14:08 milahu

last commit 53b6c8b2a9253cbf056ea3ebb077e0e08cbc5b1d on 2019-09-20, hmm ...

milahu avatar Aug 27 '21 14:08 milahu

Hello @milahu ! I too noticed that Nehbit is a bit too busy at his main job right now, and that's why I started a fork of Aether at https://github.com/Frigyes06/aether-app I'm currently working on getting CI working. If you want, you could make a PR with your improvements to that repo or help with anything else. I'd greatly appreciate it! Best, Frigyes

Frigyes06 avatar Jun 04 '23 01:06 Frigyes06