elixir-node icon indicating copy to clipboard operation
elixir-node copied to clipboard

Add configurable network ID and include it in transaction data binaries when signing

Open d-velev opened this issue 7 years ago • 2 comments

The network ID is appended to the transaction data that is being signed, meaning that transactions made in one network aren't going to be valid in another. It should be "ae_mainnet" by default

d-velev avatar Nov 07 '18 11:11 d-velev

@d-velev Could you provide a link to get more information about this?

Artur64 avatar Nov 12 '18 13:11 Artur64

@Artur64 I'm not sure where their signing is happening but this is how they transform their transaction binaries https://github.com/aeternity/epoch/blob/master/apps/aecore/src/aec_governance.erl#L217. So we must sign "ae_mainnet" <> serialized_tx and verify the same way

d-velev avatar Nov 12 '18 15:11 d-velev