aeternity icon indicating copy to clipboard operation
aeternity copied to clipboard

Add ability to retrieve whole contract state of the GA contract, more improvement suggestions

Open loxs opened this issue 3 years ago • 6 comments

https://github.com/aeternity/aeternity/blob/a3df5ba31e089c292a662a49b1ffffdef003707c/test/contracts/ga_main_w_temporary.aes#L19

As agreed in chat, please add the ability to retrieve whole contract state. But in particular the important bit is that the contract currently does not allow for retrieval of the 'master'

Other minor things that can be considered:

  • Consider changing the validator term in the whole contract to delegate as it better describes what's going on (Hans agreed to that)
  • Consider ability to change the master (transfer the GA to another master after it has been upgraded once)
  • Consider changing both the names of the file and the contract (inside the file) to something more suitable.

loxs avatar Feb 04 '23 10:02 loxs

@hanssv for awareness @rumyanar for awareness

loxs avatar Feb 04 '23 10:02 loxs

This is a contract that tests a concept not sure why the naming has any relevance - but it is open source, so feel free to make a PR 👍

hanssv avatar Feb 04 '23 11:02 hanssv

Soon it will stop testing and will start being used

loxs avatar Feb 04 '23 11:02 loxs

@loxs please keep issues self contained and independent. An external endpoint for fetching contract's state has nothing to do with contract features and should not be mixed together.

velzevur avatar Feb 06 '23 13:02 velzevur

@loxs please keep issues self contained and independent. An external endpoint for fetching contract's state has nothing to do with contract features and should not be mixed together.

isn't this about the contract itself API ? i.e. adding get_state function?

dincho avatar Feb 06 '23 13:02 dincho

@velzevur I wan to talk to you again before I create more issues, as I am not sure what is the right direction we should go regarding this. In the meantime the call to retrieve the state is probably a good idea regardless

loxs avatar Feb 06 '23 18:02 loxs