aeproject icon indicating copy to clipboard operation
aeproject copied to clipboard

refactor!: use sdk provided filesystem util, remove aeproject util implementation

Open thepiwo opened this issue 1 year ago • 4 comments

closes #474

thepiwo avatar Jul 28 '23 09:07 thepiwo

getFileSystem as exposed by the sdk is async so this will need to be a breaking change or some workaround...

thepiwo avatar Jul 28 '23 10:07 thepiwo

getFileSystem as exposed by the sdk is async so this will need to be a breaking change or some workaround...

did you ask @davidyuk why it is async? 🤔

marc0olo avatar Jul 28 '23 10:07 marc0olo

I've used non-blocking file access api, this way nodes process may request multiple files at once

davidyuk avatar Jul 28 '23 10:07 davidyuk

I made this PR breaking and will gather some more breaking changes eventually for an upcoming v5

thepiwo avatar Jul 31 '23 07:07 thepiwo