aepp-components icon indicating copy to clipboard operation
aepp-components copied to clipboard

AeIcon: Make it inline-flex only when it necessary

Open davidyuk opened this issue 6 years ago • 4 comments

I have checked styleguide, looks it doesn't break any other components/examples.

davidyuk avatar Jan 25 '19 07:01 davidyuk

@davidyuk

Lets put this as an extra prop change (extra class that can be applied), rather than making it exclusively for primary.

sadiqevani avatar Jan 29 '19 11:01 sadiqevani

Did you mean round instead of primary? Are this styles used somewhere else except round state? I can't find its usages.

davidyuk avatar Feb 01 '19 14:02 davidyuk

@davidyuk

I was thinking more of something like:

<ae-icon flex-center />
props: {
  flexCenter: Boolean
}
.ae-icon.flex-center {}

Adding those behavior modifications as class, so its not specific to one style.

sadiqevani avatar Feb 08 '19 14:02 sadiqevani

No need to add this property, parent component can modify icon styles if it is really necessary, I don't see any other cases except round.

davidyuk avatar Feb 14 '19 04:02 davidyuk