aepp-base icon indicating copy to clipboard operation
aepp-base copied to clipboard

Remove aepp browser 💣

Open davidyuk opened this issue 1 year ago • 5 comments

I have trouble detecting the navigation between apps in iframe while migrating to sdk@13 (to detect accounts aepp has access to). Instead of solving this problem, I'm proposing to remove aepp browser completely, keeping only links to other aeternity apps. After removing aepp browser, the only way to connect to app would be reverse iframe on desktop. Maybe later we would introduce a different way to communicate between mobile wallet and aepps (deeplinks?). Also, it solves the problem that aepps registry is down.

Aepps list implementation is moved from https://github.com/aeternity/aepp-base-home-page (would archive it later).

The reasons why the usual iframe approach won't be used:

  • it is less secure for an app to open itself in iframe (for example, google.com can't be opened in iframe)
  • cookies didn't get shared between apps opened in Cordova and default web browser
  • parent frame can't detect navigation between pages inside iframe, so for example, Base aepp can't show the current url correctly
  • there were issues that some APIs wasn't available in iframe, so base aepp need to proxy them (like qr code scanner), it is not available in current app-wallet connection api
  • poor UX: browser inside another browser (if not wrapped with Electron/Cordova)
  • approach was rejected by App Store (in cordova version)

This PR is supported by the Æternity Crypto Foundation

davidyuk avatar May 08 '23 07:05 davidyuk

Deployed to https://pr-1490-aepp-base.stg.aepps.com

github-actions[bot] avatar May 08 '23 07:05 github-actions[bot]

I thought the overall plan is to move more in the direction of aepp browser again? cc @kenodressel

thepiwo avatar May 08 '23 07:05 thepiwo

I think this was the general Idea but it seems it brings quite a bit of limitations. Would be nice for the superhero wallet team to explore the limitations above @paolomolo :)

kenodressel avatar May 08 '23 08:05 kenodressel

What's the up to date status of this?

dincho avatar Dec 22 '23 08:12 dincho

Not sure @paolomolo ?

kenodressel avatar Jan 03 '24 08:01 kenodressel