aepp-base icon indicating copy to clipboard operation
aepp-base copied to clipboard

Staging Aepp Base Pipeline not deploying if the first build failed after PR opening

Open davidyuk opened this issue 2 years ago • 2 comments

In case of the first build fails after PR opening, "Staging deploy" didn't gets executed. https://github.com/aeternity/aepp-base/blob/b3959bda1afb864637f9525449218eaefd26fec2/.github/workflows/staging-docker.yml#L101-L103 It also didn't gets executed in subsequent builds, because PR already opened, so a PR didn't gets deployed eventually.

It happaned to me in https://github.com/aeternity/aepp-base/pull/1472 I've tried to open https://pr-1472-aepp-base.stg.aepps.com , but there is 404.

davidyuk avatar Apr 23 '23 11:04 davidyuk

Also, is develop branch deployed somewhere?

davidyuk avatar Apr 25 '23 08:04 davidyuk

For now, we don't support syncing of initially failed PR's . You have to close and open the PR (not reopen). We have a ticket to look for such an option, but it's not implemented yet. Develop branch is not deployed currently. We have to sync with Foundation on how they want to manage this service and after that, I can take care of whatever is the decision.

mmpetarpeshev avatar Apr 26 '23 07:04 mmpetarpeshev