bctpy icon indicating copy to clipboard operation
bctpy copied to clipboard

NBS parallel

Open daorse opened this issue 1 year ago • 0 comments

Hi, I think there are at least two big issues in NBS parallel. The first one is that the random generator is not used in a suitable way for multiprocessing. As a result it uses always the same permutation. In addition to this in the final line in the main function the p values are computed using null that is full of zeros. I think null_dist should be used instead.

Thank you for your work!

daorse avatar Nov 30 '23 11:11 daorse