aesara icon indicating copy to clipboard operation
aesara copied to clipboard

implement `aesara.tensor.multiply`

Open rlouf opened this issue 3 years ago • 4 comments

For API compatibility. numpy.multiply is an alias for *, the element-wise multiplication. https://numpy.org/doc/stable/reference/generated/numpy.multiply.html?highlight=multiply#numpy.multiply

rlouf avatar Jun 21 '21 09:06 rlouf

I am new, how can I start on this issue ??

unnumsykar avatar Jul 16 '21 14:07 unnumsykar

@unnumsykar this PR could give an idea: https://github.com/aesara-devs/aesara/pull/490

ricardoV94 avatar Jul 16 '21 15:07 ricardoV94

Also, this would probably just be an alias for aesara.tensor.math.mul.

brandonwillard avatar Aug 04 '22 17:08 brandonwillard

There shouldn't be anything to implement here, the idea is to add an alias to get Aesara's API closer to numpy's. Or better, replace the use of mul by multiply, use mul as an alias and add a deprecation warning.

rlouf avatar Aug 04 '22 21:08 rlouf