aesara icon indicating copy to clipboard operation
aesara copied to clipboard

Implement `aesara.tensor.matmul`

Open rlouf opened this issue 4 years ago • 3 comments

As in https://numpy.org/doc/stable/reference/generated/numpy.matmul.html

rlouf avatar Jun 21 '21 09:06 rlouf

@brandonwillard where would the implementation be put? (basic.py vs math.py vs nlinalg.py). Also which of the input parameters should be ignored for the aesara implementation?

zoj613 avatar Jan 08 '22 17:01 zoj613

@brandonwillard where would the implementation be put? (basic.py vs math.py vs nlinalg.py).

nlinalg seems like the right place.

Also which of the input parameters should be ignored for the aesara implementation?

out, order, subok, and casting aren't relevant to Aesara right now.

brandonwillard avatar Jan 08 '22 18:01 brandonwillard

We need to finish https://github.com/aesara-devs/aesara/pull/757 in order to complete our matmul implementation. See the comments in https://github.com/aesara-devs/aesara/pull/744.

brandonwillard avatar Jul 30 '22 21:07 brandonwillard