aesara-devs
Update Scan Gibbs sampling example
This PR tries to fix #890.
The example is now working with the last version of Aesara.
Thank you for contributing. I tried to make it run on my machine (with matrix and vectors instead of shared variables), and the comments are left are the took things that prevented it from running.
N.B. We really should find a way to run
blackon our code snippets in the documentation.
And run the examples in the CI! For instance this one is not going to compile because of the use of shared variables (which are not necessary).
Just some formatting changes to match the rest of the library.
N.B. We really should find a way to run black on our code snippets in the documentation.
Have you tried using blacken-docs?
N.B. We really should find a way to run
blackon our code snippets in the documentation.And run the examples in the CI! For instance this one is not going to compile because of the use of
sharedvariables (which are not necessary).
Why shouldn't it compile and/or run?
Unless I missed something the values of the shared variables were not specified.
Unless I missed something the values of the shared variables were not specified.
They're defined, I believe, just not in the same code block.
Unless I missed something the values of the shared variables were not specified. They're defined, I believe, just not in the same code block.
I think this is making the example a bit confusing as the creation of the input variables is hidden from the user, and then the code is commented to mention you should presume the variables already exist. It would probably be easier for the understanding to have everything in the same block.
It would probably be easier for the understanding to have everything in the same block.
Indeed I always like to copy/paste examples from the documentation when I start playing with a library. I'm sure I'm not the only one.