aesara icon indicating copy to clipboard operation
aesara copied to clipboard

Published 20 hours ago • verified publisher icon aesara-devs

Remove `CholeskyGrad` Op

Open purna135 opened this issue 3 years ago • 3 comments

I'm wondering if we should remove the CholeskyGrad Op entirely because we have a working L_Op inside the Cholesky Op and are no longer using CholeskyGrad Op.

Thanks to @ricardoV94 for sharing this reference (https://github.com/aesara-devs/aesara/commit/1c8f8d6ace92683359ef74401e57a7b09a209f7e), which shows that CholeskyGrad was used in the original implementation of Cholesky but was later removed.

purna135 avatar Aug 05 '22 15:08 purna135

Yes, we should remove it.

brandonwillard avatar Aug 06 '22 17:08 brandonwillard

Hi, I am a beginner to opensource and I guess it's a beginner friendly issue so I would like to work on this.

sudarsan2k5 avatar Aug 06 '22 19:08 sudarsan2k5

Hi, I am a beginner to opensource and I guess it's a beginner friendly issue so I would like to work on this.

No problem; take a look at the developer start guide and feel free to submit a PR. If you have questions, we're on Gitter or you can open a Discussion.

brandonwillard avatar Aug 06 '22 20:08 brandonwillard